Bug 4262 - openarena: Segfault when deleting non-existent ban address 0
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: PC Linux
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL: http://bugs.debian.org/532212
Depends on:
Blocks:
 
Reported: 2009-08-22 05:19 EDT by Gonéri Le Bouder
Modified: 2009-08-24 12:01:45 EDT
1 user (show)

See Also:


Description Gonéri Le Bouder 2009-08-22 05:19:02 EDT 
Hi,

I'm one of the OpenArena maintainer.

Guillaume Delacour, send us a patch to fix a segfault. To reproduct it, you've just to type "bandel 0" in the console.

The issue is documented here:
http://bugs.debian.org/32212

The patch sounds trivial and we decide to apply it.

Best regards,

    Gonéri Le Bouder
Comment 1 Gonéri Le Bouder 2009-08-22 05:24:25 EDT 
Oopse: It's http://bugs.debian.org/532212
Comment 2 Ben Millwood 2009-08-22 10:23:51 EDT 
This bug was fixed in r1557, I think. The context for the patch doesn't match anymore, at any rate.

There are still some oddities in the ban code - sometimes serverBansCount is used as a maximum index, but if exceptions and bans both exist then the maximum will be lower because they are indexed independently. I don't think there are any severe bugs as a consequence but it might result in an error message not getting printed. I am happy to patch these issues but it will probably be at least a week until I can do so.
Comment 3 Gonéri Le Bouder 2009-08-24 12:01:45 EDT 
Thank you Ben for the feedback. I close the bug.