Bug 2387 - [PATCH] sparse cleanups, first pass
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: Macintosh All
: P2 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2005-09-22 17:54 EDT by ajax
Modified: 2007-05-21 11:23:37 EDT
0 users

See Also:


Attachments
q3-sparse-cleanups-1.patch (8.25 KB, patch)
2005-09-22 17:57 EDT, ajax
q3-sparse-cleanups-2.patch (38.52 KB, patch)
2005-09-22 19:44 EDT, ajax

Description ajax 2005-09-22 17:54:37 EDT
running sparse over a new codebase is usually a fun way to get to know it while
finding silly bugs (in either the code or in sparse).

first patch here should have no semantic changes, just cleaups.
Comment 1 ajax 2005-09-22 17:57:21 EDT
Created attachment 784 [details]
q3-sparse-cleanups-1.patch

- many instances of s/0/NULL/
- fix a few functions like void foo() {} to be void foo(void) {}
- Com_Printf was being called in a few places with an enum for the first arg
instead of a string.  pretty obvious that the enum arg should just be dropped.
Comment 2 ajax 2005-09-22 19:44:08 EDT
Created attachment 785 [details]
q3-sparse-cleanups-2.patch

first one was lame.  same thing, more files.
Comment 3 Tim Angus 2005-09-23 13:39:25 EDT
Applied.
Comment 4 Ryan C. Gordon 2007-05-21 11:23:37 EDT
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.