Bug 2408 - remove jpeglib from source
Status: RESOLVED WONTFIX
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: 1.33 SVN
Hardware: PC Linux
: P2 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2005-10-06 22:09 EDT by Jamie Wilkinson
Modified: 2007-05-21 11:23:49 EDT
0 users

See Also:


Attachments
patch makefile to build with libjpeg and fix tr_image to work with memory buffer (10.94 KB, patch)
2005-10-06 22:10 EDT, Jamie Wilkinson

Description Jamie Wilkinson 2005-10-06 22:09:11 EDT
I don't think it's worth keeping the jpeg-6 directory in the quake3 source, it's
code that is maintained elsewhere; so here's a patch that chucks it out, and
fixes LoadJPG to use memory buffer instead of a FILE * (turns out TTimo hacked
up jpeg-6 to do this already, rather than do it in tr_image.c)

Unfortunately I haven't had a chance to test this patch, so all I know is that
it builds.  I'd welcome comments from testers before applying it to SVN... I
will be able to test it later tonight when I'm not skiving off at work.
Comment 1 Jamie Wilkinson 2005-10-06 22:10:27 EDT
Created attachment 790 [details]
patch makefile to build with libjpeg and fix tr_image to work with memory buffer
Comment 2 Ludwig Nussel 2005-10-10 11:15:17 EDT
Despite what has been said on the mailinglist I agree that q3 should use the 
system libjpeg. However, your patch is not sufficient. You'd need to also 
provide a memory manager so libjpeg doesn't use malloc() but ri.Malloc(). The 
interface for that is quite complicated though so doing that is not easy. 
Therefore WONTFIX. 
Comment 3 Ryan C. Gordon 2007-05-21 11:23:49 EDT
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.