Bug 2493 - Wrong constant in MSG_WriteBits
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: unspecified
Hardware: All All
: P2 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2005-11-08 19:02 EST by Matthew R. Dempsky
Modified: 2007-05-21 11:24:33 EDT
1 user (show)

See Also:

Attachments
Patch for msg.c (418 bytes, patch)
2005-11-08 19:03 EST, Matthew R. Dempsky

Description Matthew R. Dempsky 2005-11-08 19:02:28 EST 
MSG_WriteBits increments msg->bit by 8 instead of 32 in the bits==32 case; it is 32 in the MSG_ReadBits counter part.  This seems like a bug, but I do not know for sure (or the consequences if so).
Comment 1 Matthew R. Dempsky 2005-11-08 19:03:01 EST 
Created attachment 811 [details]
Patch for msg.c
Comment 2 Tim Angus 2005-11-15 18:51:41 EST 
As far as I can tell the value of msg->bit is of no actual consequence in this case, so I've committed your fix. However, the network protocol is large and complicated, to the point where I don't pretend to understand it all. I'll leave this bug open for a week or two in case it causes any problems for people.
Comment 3 Tim Angus 2005-12-01 20:18:53 EST 
This has probably had long enough to cool off now.
Comment 4 Ryan C. Gordon 2007-05-21 11:24:33 EDT 
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.