Bug 2640 - Bugs in heartbeat sending to master servers
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: 1.33 SVN
Hardware: All Linux
: P2 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2006-04-06 09:43 EDT by Thilo Schulz
Modified: 2007-05-21 11:25:21 EDT
1 user (show)

See Also:



Description Thilo Schulz 2006-04-06 09:43:35 EDT
I discovered a little bug in sending heartbeats to master servers.
When supplying ports with the master server address string, it will discard the port setting and use the default one.
They used the wrong parameter order in strstr .. d'oh!

in sv_main.c: around line 261:
if ( !strstr( ":", sv_master[i]->string ) ) {

i'd suggest:
if ( !strchr( sv_master[i]->string, ':' ) ) {

have a nice day :)
Comment 1 Ryan C. Gordon 2007-05-21 11:25:21 EDT
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.