Bug 2785 - When Fullscreen is off, Brightness has no effect
Status: RESOLVED INVALID
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: unspecified
Hardware: PC Linux
: P2 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
: 3080
Depends on:
Blocks:
 
Reported: 2006-07-18 06:09 EDT by samuel
Modified: 2011-02-11 11:43:17 EST
5 users (show)

See Also:


Attachments
test patch that may fix the problem (766 bytes, patch)
2006-07-30 07:45 EDT, Thilo Schulz

Description samuel 2006-07-18 06:09:36 EDT
Title says it all, I'd like to play on an other display, with fullscreen OFF, as I  play with "quake3-bin" (but that's actually fullscreen, since I don't run any window manager on this display, this is so that daemon like xbindkeys can grab something.)


I'm on gentoo, using quake3-1.34_alpha789.


Note that brightness works (even if too bright) in fullscreen.
Comment 1 stahlsau 2006-07-25 01:28:11 EDT
ack, same here. As the original author stated, the brightness settings have no effect when playing in windowed mode.
Comment 2 Thilo Schulz 2006-07-30 07:45:50 EDT
Created attachment 994 [details]
test patch that may fix the problem

Please apply this patch and test whether the brightness problems still persist.
Generally, this patch reverts the brightness behaviour to id's original engine for windows rendering only. If it fixes your problems then I'm happy to apply it because ATM it doesn't do any visual difference anyways.
If it does not fix it then I guess you should get better hardware/drivers/xserver because here changing brightness works. I'm using nvidia hardware and their alas - closed source drivers.
Comment 3 Thilo Schulz 2006-07-30 07:46:55 EDT
> for windows rendering only.

Sorry I meant "for windowed" rendering, not windows rendering.
Comment 4 samuel 2006-07-30 16:47:16 EDT
I tried the patch, but it didn't work. But I notice, I wrongly described the 'bug' 


I tried this with the patch and without, behaviour is the same
you can see the bug if you launch quake3 on an other display, without any display manager:

xinit /usr/bin/xterm -- :1
in the term, run quake3 , with fullscreen Off => brightness has no effect
Now, quit the game, and back in the term, launch a window manager, eg:
fvwm &> /dev/null &

then launch the game again
quake3
Now the brightness works, even with fullscreen OFF




I even found a little workaround to make brightness working with fullscreen off AND without any window manager:

xinit /usr/games/bin/quake3 -- :1

when you inside the game, ALT+ENTER will make it fullscreen, ALT+ENTER will bring you back with fullscreen off, and now brightness works as expected (with fullscreen off)



any idea?
thanks
Comment 5 samuel 2006-07-31 03:39:38 EDT
(In reply to comment #4)
> ALT+ENTER will make it fullscreen, ALT+ENTER will
> bring you back with fullscreen off


This is because I start in window mode, if I start the game directly in fullscreen  on (set on the previous game) then, ALT+ENTER, will make fullscreen off, and brightness works as expected:).

So the bug only appear if I start the game with fullscreen off
Comment 6 Erik Auerswald 2006-09-02 15:24:15 EDT
when starting the game in windowed mode the brightness controls affect the whole desktop, not just the ioquake3 window (at least on linux/x86 with nvidia binary drivers) -- this does not change after switching to/from fullscreen mode
Comment 7 Ryan C. Gordon 2007-05-21 11:22:12 EDT
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.

Comment 8 Tim Angus 2007-08-22 18:10:34 EDT
*** Bug 3080 has been marked as a duplicate of this bug. ***
Comment 9 Zachary J. Slater 2008-12-30 00:43:10 EST
Is this still broken?
Comment 10 /dev/humancontroller 2009-01-02 09:07:38 EST
Yes.

On my Windows system, gamma changing works in both fullscreen and windowed mode, except in windowed mode if I switch from fullscreen during run (Alt+Enter). When I do that, the gamma is locked to some weird value: if I started the binary in windowed mode, then it is locked to the gamma value that was set when I switched to fullscreen; if I started the binary in fullscreen, then it is locked to 1.0. So I must start the binary in windowed mode to be able to change the gamma during run in windowed mode, but I am actually able to set any value.

The patch does nothing for me as well.
Comment 11 Ryan C. Gordon 2009-09-13 21:52:25 EDT
My memory of this is extremely flakey, but I seem to recall either SDL or X11 changed something that broke gamma ramps...but I could be totally wrong.

--ryan.
Comment 12 Zachary J. Slater 2010-10-19 02:46:02 EDT
Is http://bugzilla.libsdl.org/show_bug.cgi?id=971 the SDL bug?
Comment 13 Thilo Schulz 2011-02-11 09:58:38 EST
Okay, I tested on some recent software (X.Org version: 1.8.1, SDL1.2.14) and I can modify brightness when I started in fullscreen and when I started in windowed mode. When in windowed mode, all of the desktop's brightness gets changed but I guess there's nothing we can do here.
Comment 14 Roman "kevlarman" Tetelman 2011-02-11 11:43:17 EST
(In reply to comment #13)
> Okay, I tested on some recent software (X.Org version: 1.8.1, SDL1.2.14) and I
> can modify brightness when I started in fullscreen and when I started in
> windowed mode. When in windowed mode, all of the desktop's brightness gets
> changed but I guess there's nothing we can do here.

this bug doesn't seem to affect nvidia's binary driver (all the others are affected), however this is an sdl bug, not ioq3: http://bugzilla.libsdl.org/show_bug.cgi?id=971