Bug 2796 - Bug in GLX mode detection causes GLX failure
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: 1.33 SVN
Hardware: PC Linux
: P2 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
: 2795
Depends on:
Blocks:
 
Reported: 2006-07-26 18:37 EDT by Phil Bordelon
Modified: 2007-05-21 11:26:52 EDT
0 users

See Also:


Attachments
One-line fix against trunk to help find the proper GL settings. (325 bytes, patch)
2006-07-26 18:38 EDT, Phil Bordelon

Description Phil Bordelon 2006-07-26 18:37:40 EDT
See:

https://bugzilla.icculus.org/show_bug.cgi?id=2795

Basically, my nVidia card is in 16bpp mode in X, and so none of the bpc modes have 8 bits.  When the line resetting sdlcolorbits to 4 /in each run of the detection loop/ was removed, it forces it to 8 on every test after the first.  Oops.  It's a one-line fix, and it makes Tremulous launch properly on my machine; I'm operating under the assumption (possibly erroneous) that the fix should go upstream as well.

Feel free to disregard this if it doesn't apply to ioq3, but I feel like it probably does.
Comment 1 Phil Bordelon 2006-07-26 18:38:34 EDT
Created attachment 984 [details]
One-line fix against trunk to help find the proper GL settings.

Here is the aforementioned patch.  It's a one-liner.  As stated above, it fixes problems with Tremulous; I'm assuming it won't hurt ioq3 either.
Comment 2 Phil Bordelon 2006-07-26 20:10:44 EDT
Further exploration shows that this is definitely a bug in ioq3.  (The patch is essentially a revert of r713.)  Timbo said that he'd wait for the fix upstream instead of merging it separately.
Comment 3 Tim Angus 2006-07-28 04:20:00 EDT
*** Bug 2795 has been marked as a duplicate of this bug. ***
Comment 4 Thilo Schulz 2006-07-30 07:10:13 EDT
You're right. I failed to notice that was in a for loop. Sorry. Fixed in SVN
Comment 5 Ryan C. Gordon 2007-05-21 11:26:52 EDT
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.