Bug 2871 - E3 Hack Bug left on in cg_main.c for teamoverlay cvar so that tinfo is always sent...
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC All
: P2 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2006-09-19 17:09 EDT by ensiform
Modified: 2007-05-21 11:27:03 EDT
0 users

See Also:


Description ensiform 2006-09-19 17:09:19 EDT 
iD left the E3 hack in code for some reason telling overlay to always send to server and thus always try to send tinfo command back to client, could cause extra lag when it does not need to.

http://svn.icculus.org/quake3/trunk/code/cgame/cg_main.c?view=markup

	// If team overlay is on, ask for updates from the server.  If its off,
	// let the server know so we don't receive it
	if ( drawTeamOverlayModificationCount != cg_drawTeamOverlay.modificationCount ) {
		drawTeamOverlayModificationCount = cg_drawTeamOverlay.modificationCount;

		if ( cg_drawTeamOverlay.integer > 0 ) {
			trap_Cvar_Set( "teamoverlay", "1" );
		} else {
			trap_Cvar_Set( "teamoverlay", "0" );
		}
		// FIXME E3 HACK
		trap_Cvar_Set( "teamoverlay", "1" );
	}

remove the force set of cvar.
Comment 1 Thilo Schulz 2006-11-25 06:03:52 EST 
commited, thanks
Comment 2 Ryan C. Gordon 2007-05-21 11:27:03 EDT 
Setting a QA contact on all ioquake3 bugs, even resolved ones. Sorry if you get a flood of email from this, it should only happen once. Apologies for the incovenience.

--ryan.