Bug 3131 - Sort install sources by location, then option...
Status: RESOLVED MOVED
Alias: None
Product: MojoSetup
Classification: Unclassified
Component: Everything
Version: unspecified
Hardware: All All
: P3 normal
Assignee: Ryan C. Gordon
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2007-05-22 03:50 EDT by Ryan C. Gordon
Modified: 2022-05-20 13:46:27 EDT
0 users

See Also:



Description Ryan C. Gordon 2007-05-22 03:50:34 EDT
...right now we split the Setup.File elements into tables based on their source locations: base:///, media://, or a network protocol. These tables are indexed by the Setup.File element to find the original Option, and when we install then, we install everything in one of the split out tables in whatever order Lua's pairs() gives them to us.

There is a high-level order already, which remains important: do downloads first, because you're out of luck if any fail, then install from media:// sources, so you can fail sooner than later when the user finds he's missing disc 3 of 70, then base:/// sources, since they tend to be (most) reliable.

This order shouldn't change.

However, this causes the installer to jump around between Setup.Options in a confusing way, since within that ordering, it's fair game as to what pops out of pairs() first. Even in two runs of the same installer, a given table may hash differently, causing a different install order, and the progress to keep popping up different component names it otherwise appears to have already completed.

So within a given set of Setup.Files, it should install everything grouped under the same Setup.Option before moving on to the next (and maybe sort that group by config file order so even that is reliable).

--ryan.
Comment 1 Ryan C. Gordon 2022-05-20 13:46:27 EDT
This bug report has migrated to our GitHub issue tracker:

https://github.com/icculus/mojosetup/issues/34