Bug 3268 - Mac OS X ppc build still relies on Carbon API
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: 1.33 SVN
Hardware: Macintosh MacOS X
: P3 minor
Assignee: Tony J. White
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2007-07-19 00:40 EDT by Tony J. White
Modified: 2007-09-19 01:45:04 EDT
0 users

See Also:

Attachments
remove Carbon deps (3.20 KB, patch)
2007-07-19 00:43 EDT, Tony J. White

Description Tony J. White 2007-07-19 00:40:08 EDT 
http://tremulous.net/phpBB2/viewtopic.php?t=5608

As pointed out in this thread, the Carbon call MakeDataExecutable( ... ) can be
replaced with msync( ..., MS_INVALIDATE ) removing the need for linking with
the Carbon framework for the PPC mac build.

The Gestalt() Carbon function was also being used to detect Altivec capability, so I replaced this with the mach-o check SDL uses.

Attached patch seems to work fine with both a OS X 10.4 compile and one built against the 10.2.8SDK.
Comment 1 Tony J. White 2007-07-19 00:43:08 EDT 
Created attachment 1440 [details]
remove Carbon deps

remove Carbon dependencies

also removes some spammy printf's for local IP detection I added a long time ago
Comment 2 Tony J. White 2007-07-19 00:44:59 EDT 
Oh, I forgot.  I also added the msync() call for non-Mac OS X PPC systems because it seems like a proper thing to do.

Can someone please test on Linux PPC?
Comment 3 Tony J. White 2007-09-19 01:45:04 EDT 
reopen if this change causes linux ppc issues i guess