Bug 3393 - Blank user names still possible
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: All All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2007-10-20 07:24 EDT by Michael Jard
Modified: 2007-11-02 19:58:02 EDT
0 users

See Also:


Attachments
patch checks for color codes before spaces (596 bytes, patch)
2007-10-20 07:25 EDT, Michael Jard

Description Michael Jard 2007-10-20 07:24:44 EDT
While the original code did do some checking on usernames to make sure they didn't have leading spaces, it would completely ignore the spaces if prepended with a color code, letting the user have a blank name, or atleast a name with 3 spaces before the rest of the text. 

This would allow players to "clone" other players names, enabling them to hide while cheating. I've briefly tested this patch and assume it will work correctly, though I haven't checked it against any mods.

This patch affects game code only, it will be up to mod developers to incorporate it into their games. Though it is an easy fix.
Comment 1 Michael Jard 2007-10-20 07:25:55 EDT
Created attachment 1550 [details]
patch checks for color codes before spaces
Comment 2 Tim Angus 2007-11-02 19:57:14 EDT
Committed r1204.
Comment 3 Tim Angus 2007-11-02 19:58:02 EDT
.