Bug 3423 - Exploit allows sv_maxping to be overriden
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2007-11-13 11:53 EST by Amanieu d'Antras
Modified: 2009-10-08 16:03:40 EDT
3 users (show)

See Also:


Attachments
Proposed patch based on svn1035 (491 bytes, patch)
2007-11-13 12:07 EST, Amanieu d'Antras
Proposed patch based on svn 1043 (525 bytes, patch)
2007-12-07 12:14 EST, Amanieu d'Antras
Proposed patch based on svn 1043 (1.53 KB, patch)
2007-12-07 12:18 EST, Amanieu d'Antras
Alternative patch based on svn 1043 (1.08 KB, patch)
2007-12-07 12:48 EST, Amanieu d'Antras
Alternative patch based on svn 1043 (2.02 KB, patch)
2007-12-07 13:08 EST, Amanieu d'Antras

Description Amanieu d'Antras 2007-11-13 11:53:21 EST
Because the server will reuse a challenge if it already exists, it is possible to exploit this as follows:
1 - Ask for a challenge
2 - Wait for reply
3 - Save the challenge number
4 - Ask for a challenge again
5 - Immediately after send a connect message with the saved challenge number

This can be done with stock tremulous by increasing the timescale cvar while in the menu to trigger the resend faster than normal.
Comment 1 Amanieu d'Antras 2007-11-13 12:07:39 EST
Created attachment 1571 [details]
Proposed patch based on svn1035

This patch simply resets the challenge number to a random value if it already exists.
Comment 2 Amanieu d'Antras 2007-12-07 12:14:20 EST
Created attachment 1607 [details]
Proposed patch based on svn 1043

Disables my patch when there is no max ping, caused problems on servers without max ping.
Comment 3 Amanieu d'Antras 2007-12-07 12:18:40 EST
Created attachment 1608 [details]
Proposed patch based on svn 1043

An alternative patch, much cleaner implementation, the client gets the correct error message ("low pings only" instead of "bad challenge") and client is allowed to take > 3 seconds to connect.
Comment 4 Amanieu d'Antras 2007-12-07 12:48:16 EST
Created attachment 1609 [details]
Alternative patch based on svn 1043

Sorry about the previous patch, I totally messed it up. This one should work.
Comment 5 Amanieu d'Antras 2007-12-07 13:08:10 EST
Created attachment 1610 [details]
Alternative patch based on svn 1043

Fixes a few bugs
Comment 6 Chris "Lakitu7" Schwarz 2009-03-06 19:39:03 EST
We should reassign this to ioq3, right?
Comment 7 Ben Millwood 2009-06-05 20:45:09 EDT
Yeah, I agree.
Comment 8 Thilo Schulz 2009-10-08 16:03:40 EDT
Fixed in svn rev. 1649