Bug 3460 - makefile explodes as of svn 1217 on ppc mac
Status: RESOLVED WORKSFORME
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: Macintosh MacOS X
: P3 critical
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2007-12-06 19:53 EST by doomagent13
Modified: 2008-07-04 14:27:37 EDT
0 users

See Also:


Attachments
A fix to the makefile on ppc mac (641 bytes, patch)
2007-12-06 21:29 EST, doomagent13
A refinement of my fix. (537 bytes, patch)
2007-12-07 22:52 EST, doomagent13

Description doomagent13 2007-12-06 19:53:04 EST
The removal of the Mac specific uname causes the arch to be recorded as "Power Macintosh".  This leads to the creation of gamePower, cgamePower, and uiPower, none of which should work. (I found this out in the Tremulous source, but it is based off of q3.)  It also spams that there is no definition of target Macintosh.
Comment 1 doomagent13 2007-12-06 21:29:45 EST
Created attachment 1606 [details]
A fix to the makefile on ppc mac

NOTE:  This patch was made against Tremulous, but Tremulous *is* Quake3 at the level that this patch deals with.
Comment 2 Tim Angus 2007-12-07 05:14:15 EST
Fair enough. What version of OS X are you running? Fixed in 1228/1229.
Comment 3 doomagent13 2007-12-07 06:58:55 EST
10.4.10 at the moment.  I dont know when I'll move up to 10.5.  Heh, maybe it worked as it was supposed to at 10.5.  That would be ironic.
Comment 4 Tim Angus 2007-12-07 07:05:06 EST
It probably will. I think Apple have fallen into line as far as uname goes with newer releases.
Comment 5 doomagent13 2007-12-07 22:51:40 EST
I have access to an Intel Mac, and it handles the old format fine.  So I rewrote my fix to only catch the problem I found, while letting it work as it was otherwise supposed to.
Comment 6 doomagent13 2007-12-07 22:52:58 EST
Created attachment 1612 [details]
A refinement of my fix.

I dont know this language very well, so there may be a more elegant solution, but it appears to work.
Comment 7 Ryan C. Gordon 2008-06-01 01:04:29 EDT
I don't know if this ever made it into Subversion or what, but the latest is building fine on PowerPC and Intel Mac OS X for me.

--ryan.


Comment 8 Zachary J. Slater 2008-07-04 14:27:37 EDT
Marking resolved, please reopen if this is still an issue.