Bug 3478 - Overbrights do not work on Windows
Status: CLOSED WORKSFORME
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: GIT MASTER
Hardware: PC Windows Vista
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
: 3477
Depends on:
Blocks:
 
Reported: 2007-12-18 06:47 EST by Jay Weisskopf
Modified: 2008-07-05 03:51:56 EDT
0 users

See Also:


Description Jay Weisskopf 2007-12-18 06:47:50 EST 
Overbrights do not work on Windows. Changing values for r_overbrightbits and r_mapoverbrightbits (I don't remember how they're capitalized off the top of my head) had no effect. However, they did work properly in id's 1.32c client.

I will probably test and see if it worked before the unified-SDL merge and add some more information.
Comment 1 Jay Weisskopf 2007-12-18 06:52:23 EST 
Upon further investigation, it seems that overbrights only work if glConfig.deviceSupportsGamma is true. This is set in sdl_glimp.c with the line glConfig.deviceSupportsGamma = !!( SDL_SetGamma( 1.0f, 1.0f, 1.0f ) >= 0 );

I guess this is an SDL problem. Overbrights function properly in id's client and before the unified-SDL merge.
Comment 2 Jay Weisskopf 2007-12-18 06:58:33 EST 
*** Bug 3477 has been marked as a duplicate of this bug. ***
Comment 3 Zachary J. Slater 2008-07-05 03:14:09 EDT 
SDL problem as in our implementation, or SDL problem as in SDL is jacked?
Comment 4 Jay Weisskopf 2008-07-05 03:37:26 EDT 
I can't reproduce this anymore, and I'm not really sure why I was messing with it in the first place. I think maps appeared overly dark at the time. Either way, I've get a new computer and r_mapOverBrightBits seems to work now.
Comment 5 Zachary J. Slater 2008-07-05 03:51:56 EDT 
I like that. Shutting it down.