Bug 3567 - small bug in Ogg Vorbis code
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Sound
Version: GIT MASTER
Hardware: All All
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-03-11 14:48 EDT by Joerg Dietrich
Modified: 2008-03-11 17:44:44 EDT
0 users

See Also:

Attachments
the actual patch (295 bytes, patch)
2008-03-11 14:49 EDT, Joerg Dietrich

Description Joerg Dietrich 2008-03-11 14:48:23 EDT 
After Robert Beckebans found a bug in the Ogg-Vorbis code
(fixed in r1270) I was searching for the
reason for this bug. It turned out that the ioQuake3.org
implementation of fseek() in FS_Seek() in code/qcommon/files.c
deviates a bit from standard behaviour. It sometimes returns 
the offset insteed of zero on succuss.
The appended patch adjusts the Ogg Vorbis code to this behaviour.
Comment 1 Joerg Dietrich 2008-03-11 14:49:31 EDT 
Created attachment 1702 [details]
the actual patch
Comment 2 Tim Angus 2008-03-11 17:44:44 EDT 
Fixed in r1271. Better not to gzip patches if possible; they can't be viewed directly in the web browser in this case. Thanks.