Bug 3636 - /set[s|u|a]'d cvars don't get sent/archived
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-05-08 08:03 EDT by /dev/humancontroller
Modified: 2009-10-19 12:52:35 EDT
1 user (show)

See Also:

Attachments
set cvar modification flags accordingly (1.62 KB, patch)
2008-05-09 07:04 EDT, /dev/humancontroller

Description /dev/humancontroller 2008-05-08 08:03:43 EDT 
Cvar_Set_f() is missing a
  cvar_modifiedFlags |= v->flags
at the end.
Comment 1 /dev/humancontroller 2008-05-09 07:04:34 EDT 
Created attachment 1754 [details]
set cvar modification flags accordingly

Actually, to keep the purpose, we should only mark a modification flag, if we are introducing a new variable of a give type.
Comment 2 Ludwig Nussel 2009-05-08 06:03:23 EDT 
so could you rework the patch to set the modification flags correctly?
Comment 3 /dev/humancontroller 2009-05-08 14:28:37 EDT 
What is wrong with it?

PS: why not (re)use Cmd_ArgsFrom()?
Comment 4 Thilo Schulz 2009-10-19 12:52:35 EDT 
Applied in rev. 1684, thank you.