Bug 3704 - file references outside the specified paths
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-06-29 02:32 EDT by /dev/humancontroller
Modified: 2009-10-17 19:50:14 EDT
1 user (show)

See Also:


Description /dev/humancontroller 2008-06-29 02:32:21 EDT 
As described by the files.c comment:
No other directories outside of the base game and current game will ever be referenced by filesystem functions.

Yes, is's good to limit limit the access to the specified paths only. Yet weirdly, I see things like botlib.log being created in the current directory. DLLs are also searched for in the cwd first. I don't know of others cases right now, but I think such things should not happen.
Comment 1 Thilo Schulz 2009-10-17 19:50:14 EDT 
I removed the CWD check for loading of DLLs, plus made botlib loading only for developers. botlib is using its own file implementations so there is indeed no checking done though you cannot modify botlib filename. This should be ok and will conclude this bug.