Bug 3726 - make-macosx-ub.sh error aborting and directory changing
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P3 enhancement
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-07-20 07:55 EDT by Ben Millwood
Modified: 2008-07-20 13:43:50 EDT
0 users

See Also:

Attachments
make-macosx-ub.sh improvements (2.07 KB, patch)
2008-07-20 07:56 EDT, Ben Millwood

Description Ben Millwood 2008-07-20 07:55:02 EDT 
There are a couple of cases in the make-macosx-ub.sh script where an unrecoverable error does not cause the script to exit, or does not exit as promptly as it could, causing misleading, redundant, or useless error messages to be printed.
The patch I am about to attach addresses these issues, and also adds some attempt to change to the right directory before execution.

I realise it's usually more convenient to open separate bugs for arguably separate issues, but theses issues are so small individually I felt it wasn't worth it.
Comment 1 Ben Millwood 2008-07-20 07:56:13 EDT 
Created attachment 1809 [details]
make-macosx-ub.sh improvements
Comment 2 Zachary J. Slater 2008-07-20 13:43:50 EDT 
Fixed in revision 1430, thanks for the patch.