Bug 3729 - server dependencies on client.h
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: PC Linux
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-07-26 10:11 EDT by Ben Millwood
Modified: 2008-08-22 18:47:52 EDT
0 users

See Also:


Attachments
don't include client.h where it isn't needed (1.64 KB, patch)
2008-07-26 10:12 EDT, Ben Millwood

Description Ben Millwood 2008-07-26 10:11:27 EDT
Building the dedicated server uses files such as code/qcommon/unzip.c, code/null/null_client.c and some others, and these files include client.h
This is a problem because it means that building the dedicated server requires the speex header files, despite the fact that as far as I can tell the server doesn't require any of the libraries or codecs.
In most cases, these includes just need one or two of the header files included in client.h, rather than that file itself - in some cases, the header files aren't needed at all. I'm going to attach a patch that sorts these issues in a second.

It was difficult for me to test this properly since I can't get voip working *anyway* (probably my hardware or openal or something), but I don't see how it could break anything.
Comment 1 Ben Millwood 2008-07-26 10:12:21 EDT
Created attachment 1810 [details]
don't include client.h where it isn't needed
Comment 2 Tim Angus 2008-08-22 18:47:52 EDT
Fixed in r1456.