Bug 3793 - Favorites menu is broken after IPV6 additions
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-10-04 15:10 EDT by Chris "Lakitu7" Schwarz
Modified: 2009-05-21 20:34:50 EDT
1 user (show)

See Also:

Attachments
fixes favourites(Tremulous) (581 bytes, application/octet-stream)
2008-10-05 10:27 EDT, slacker

Description Chris "Lakitu7" Schwarz 2008-10-04 15:10:20 EDT 
The Favorites menu behaves strangely in SVN clients. 

We have a flavor of this bug (and a fix) over in Tremulous as: https://bugzilla.icculus.org/show_bug.cgi?id=3723

To verify if this is an IOQ3 bug as well, I joined a set of servers and added them to Favorites. Now when I enter the the Favorites menu a seemingly random subset appears. The counters at the bottom tell me "X of X" where X is less than the number of servers I added and both numbers are the same, so it's not the filters. 

The fix that definitely works for Tremulous doesn't work for me when applied to IOQ3. Instead I end up with slightly different erratic behavior where the favorites are all listed, but the last one is corrupted and shows up with incorrect info as a timed-out listing. However I repeat that the overall behavior of all of this seems rather erratic in ioq3 so it makes a fully repeatable specific test case difficult to come by. My complete lack previous of experience with the q3 internal server browser may also contribute to this if there are some options someplace that I'm totally missing.
Comment 1 slacker 2008-10-05 10:27:23 EDT 
Created attachment 1880 [details]
fixes favourites(Tremulous)

i did this for tremulous but itll work for quake3 too (with minor changes) its 1 line a function that was forgotten
Comment 2 Thilo Schulz 2009-05-21 20:34:50 EDT 
The given "fix" shouldn't have anything to do with favorites, as when the button "add favorite" is clicked on serverinfo, the address from cl_currentServerAddress,  not from LAN_GetServerInfo. Still, the addr key in the keystring should contain a port number, so I committed your fix.

As to the strange serverlist thing: I tried to reproduce it but wasn't able to. If servers are not reachable or they don't respond, an empty line is displayed. Also, if you connected via a domain name instead of an ip and then add it to favorites the server won't really be added as the ui will only accept ip based addresses. This may explain the trouble you have.