Bug 3813 - Makefile fixes
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-10-24 14:18 EDT by Przemysław Iskra
Modified: 2008-11-10 04:49:03 EST
0 users

See Also:

Attachments
x86_64_assembler typo (431 bytes, patch)
2008-10-24 14:19 EDT, Przemysław Iskra
LDFLAGS vs LIBS (10.21 KB, patch)
2008-10-24 14:26 EDT, Przemysław Iskra
migw32 shell problems (652 bytes, patch)
2008-11-09 12:23 EST, Przemysław Iskra

Description Przemysław Iskra 2008-10-24 14:18:17 EDT 
Makefile is much nicer than the original one but still needs some cleanups.
Comment 1 Przemysław Iskra 2008-10-24 14:19:27 EDT 
Created attachment 1906 [details]
x86_64_assembler typo

x86_64_assembler should use separate object file for dedicated server
Comment 2 Przemysław Iskra 2008-10-24 14:26:02 EDT 
Created attachment 1907 [details]
LDFLAGS vs LIBS

libraries do not belong to LDFLAGS.
Patch creates separate *LIBS variables for libraries, leaving LDFLAGS for real flags, like -shared or --as-needed. Also CFLAGS are used when linking: -m32/-m64 belongs to CFLAGS, not LDFLAGS; linker additionally optimizes output file when -O* is in flags.
Comment 3 Ludwig Nussel 2008-11-02 12:33:06 EST 
both patches applied
Comment 4 Ludwig Nussel 2008-11-02 12:33:40 EST 
-> fixed
Comment 5 Przemysław Iskra 2008-11-09 12:23:24 EST 
Created attachment 1917 [details]
migw32 shell problems

migw32 shell has problems with empty "for" loops, problem appears when LDFLAGS is empty
Comment 6 Przemysław Iskra 2008-11-09 12:24:04 EST 
"LDFLAGS vs LIBS" isn't completely harmless on migw32
Comment 7 Ludwig Nussel 2008-11-10 04:49:03 EST 
applied