Bug 3831 - Sys_SockaddrToString inputlen wrong size
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC OpenBSD
: P3 blocker
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-10-29 03:11 EDT by agent59692154
Modified: 2008-10-29 11:58:53 EDT
0 users

See Also:

Attachments
Proposed fix for the issue (1.25 KB, patch)
2008-10-29 03:12 EDT, agent59692154

Description agent59692154 2008-10-29 03:11:35 EDT 
inputlen passed to Sys_SockaddrToString is a wrong size which causes error
on OpenBSD's getnameinfo() implemention.
Comment 1 agent59692154 2008-10-29 03:12:35 EDT 
Created attachment 1911 [details]
Proposed fix for the issue
Comment 2 Thilo Schulz 2008-10-29 11:58:53 EDT 
Hm. the salen of sockaddr_storage is used, and the passed structure actually has as much allocated memory available for safe writing.

I still applied the patch, since IMHO the RFC standard is not fully clear about what salen should be passed, and this certainly won't break the functionality on other OS.