Bug 3849 - cl_input.c - const declaration in wrong order
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Sound
Version: GIT MASTER
Hardware: PC Windows 2000
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2008-11-09 22:08 EST by Monk
Modified: 2008-11-10 04:48:27 EST
0 users

See Also:


Attachments
Diff to swap lines 784 and 785 (526 bytes, patch)
2008-11-09 22:10 EST, Monk

Description Monk 2008-11-09 22:08:47 EST
cl_input.c, the lines 785 and 784 should be swapped.  The line starting with "const char *ptr" should appear before the line starting with "clc.voipTarget1".  zinx from IRC tells me that it's some C++/C99 assumption about out-of-order variable declaration or some such tomfoolery.

I ran into this while trying to get USE_VOIP working with Visual Studio 2005.

I will attach a diff that I hope will work.
Comment 1 Monk 2008-11-09 22:10:30 EST
Created attachment 1919 [details]
Diff to swap lines 784 and 785

If this doesn't work for people, I can just attach the entire cl_input.c that I modified.  I have not modified anything else from SVN for this file besides swapping those two lines.
Comment 2 Ludwig Nussel 2008-11-10 04:48:27 EST
applied, thanks.
please just use 'svn diff' next time.