Bug 3941 - Symlinks don't get deleted - Uninstallation fails
Status: RESOLVED FIXED
Alias: None
Product: MojoSetup
Classification: Unclassified
Component: Everything
Version: unspecified
Hardware: PC Linux
: P3 normal
Assignee: Ryan C. Gordon
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2009-01-17 06:13 EST by kratz00
Modified: 2022-05-20 13:53:10 EDT
1 user (show)

See Also:


Description kratz00 2009-01-17 06:13:23 EST 
In my test setup two files get installed:

file1: is a regular file
file2: is a symbolic link to file1

If I run the uninstall script the symlink is not deleted and the uninstallation fails because the installer can not remove the installation directory which is not empty.

Problem is file1 is deleted before file2.

mojosetup_mainline.lua:146 - function do_delete
The call to MojoSetup.platform.exists returns false for file2 and so this function does not delete file2.

The cause of this is in:
platform_unix.c:564 - function MojoPlatform_exists
access(dir, F_OK) return -1 because file1 was deleted and file2 is now a broken symlink.
Comment 1 Reto Schneider 2009-01-31 19:08:42 EST 
Is this but extremely hard to fix? Is there a ETA for a (hopefully coming) fix?

Thanks,
Reto
Comment 2 Ryan C. Gordon 2009-02-05 01:27:46 EST 
Should be fixed in hg revision 616:f7597a3863cd ... please let me know if it isn't.

--ryan.
Comment 3 kratz00 2009-02-06 12:57:15 EST 
My test installer scenario uninstalls fine now.
Thanks for the fix.
Comment 4 Ryan C. Gordon 2022-05-20 13:53:10 EDT 
This bug report has migrated to our GitHub issue tracker:

https://github.com/icculus/mojosetup/issues/48