Bug 3965 - Client sends 0-length command to cgame during map_restart
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: All All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2009-02-10 22:55 EST by Chris "Lakitu7" Schwarz
Modified: 2009-09-15 02:15:15 EDT
1 user (show)

See Also:


Attachments
fix (510 bytes, patch)
2009-02-10 22:56 EST, Chris "Lakitu7" Schwarz

Description Chris "Lakitu7" Schwarz 2009-02-10 22:55:57 EST
During map-restart, the client attempts to send the map_restart command to cgame. Before doing so, it calls Con_ClearNotify(), which has an instance of Cmd_TokenizeString() that messes everything up and results in sending a 0-length empty command to cgame instead. The result is fairly minimal and restarts appear to work despite the issue, but in Tremulous, where we noticed this, our cgame prints a warning message that caused us to track down the bug. 

If you look a few lines up at the code for "cs", the same issue occurs with handling the "cs" command and the same fix is applied, so this should be pretty open-and-shut. 

Thank Amanieu.
Comment 1 Chris "Lakitu7" Schwarz 2009-02-10 22:56:26 EST
Created attachment 1968 [details]
fix
Comment 2 Ryan C. Gordon 2009-09-15 02:15:15 EDT
Fixed in svn revision #1621, thanks!

--ryan.