Bug 4012 - Remove islower, isupper, and isalpha functions
Status: RESOLVED WONTFIX
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P3 enhancement
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2009-03-10 16:15 EDT by Matt Turner
Modified: 2009-09-14 07:22:12 EDT
3 users (show)

See Also:

Attachments
Remove Q_is{alpha,upper,lower} (2.98 KB, patch)
2009-03-10 16:15 EDT, Matt Turner

Description Matt Turner 2009-03-10 16:15:17 EDT 
Created attachment 2015 [details]
Remove Q_is{alpha,upper,lower}

C library provides this, we should not.

Patch kills off the code and replaces calls to Q_is{alpha,upper,lower} to the appropriate C function.
Comment 1 Ludwig Nussel 2009-05-02 14:02:56 EDT 
makes sense. Could you modify your patch to replace the prototypes in q_shared.h with defines for compatibility instead of removing them please?
Comment 2 Ryan C. Gordon 2009-09-14 00:53:18 EDT 
I suspect that the concern was that is*() is locale dependent, whereas Quake wants to limit these tests to US-ASCII.

--ryan.
Comment 3 Tim Angus 2009-09-14 07:22:12 EDT 
Meh.