Bug 4054 - STRING and XSTRING macros defined twice
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2009-05-03 09:44 EDT by Ben Millwood
Modified: 2009-05-05 14:19:37 EDT
1 user (show)

See Also:

Attachments
STRING and XSTRING in q_shared.h (1.37 KB, patch)
2009-05-03 09:44 EDT, Ben Millwood
unconditional (1.32 KB, patch)
2009-05-03 17:32 EDT, Ben Millwood

Description Ben Millwood 2009-05-03 09:44:23 EDT 
Created attachment 2049 [details]
STRING and XSTRING in q_shared.h

The definitions don't actually conflict, but from a developer's point of view it's annoying to have the same (useful) macro defined in several different places.
This bug is beyond trivial but I want to add a third usage to Tremulous and it's starting to get a little messy. Attached is a patch that puts the definition in q_shared.h where it belongs.
Comment 1 Ludwig Nussel 2009-05-03 14:36:43 EDT 
why does the #define need to be conditional?
Comment 2 Ben Millwood 2009-05-03 17:32:53 EDT 
Created attachment 2050 [details]
unconditional

Force of habit :)

Attached is previous with #[end]if removed
Comment 3 Ludwig Nussel 2009-05-05 14:19:37 EDT 
applied, thanks