Bug 4058 - More changes to Solaris packaging ..
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: Sun SunOS
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2009-05-06 09:04 EDT by Vincent Cojot
Modified: 2009-09-14 21:49:24 EDT
1 user (show)

See Also:


Attachments
Diffs for trunk/misc/setup/pkg files... (4.06 KB, patch)
2009-05-06 09:06 EDT, Vincent Cojot
Modified patch for safer LD_LIBRARY_PATH handling. (4.03 KB, patch)
2009-05-08 06:33 EDT, Vincent Cojot
Latest modified patch (plese use this one). (5.17 KB, patch)
2009-05-15 05:04 EDT, Vincent Cojot

Description Vincent Cojot 2009-05-06 09:04:16 EDT
This patch changes the package dependencies and isolates the demo data file to a separate Solaris package. Please apply.. it touches only some files under trunk/misc/setup.pkg (Solaris only stuff).
Comment 1 Vincent Cojot 2009-05-06 09:06:06 EDT
Created attachment 2055 [details]
Diffs for trunk/misc/setup/pkg files...
Comment 2 Ludwig Nussel 2009-05-08 05:06:59 EDT
LD_LIBRARY_PATH=${IOQ3_DIR}:${LD_LIBRARY_PATH} will open a security hole if LD_LIBRARY_PATH was unset before (loads libs from current dir then). Don't do that. Why don't you use the same start script we use on Linux anyways?
Comment 3 Vincent Cojot 2009-05-08 06:33:11 EDT
Hi luwdig,
I back-ported the safer routines from the Linux startup script, thanks for catching that.
The Linux and Solaris startup scripts are quite different because I need to force certain parameters on Solaris in order to make sure the game runs. If we were to share a common script, then it'd be harder to maintain (IMHO) and I don't want to impact Linux platforms with a set of Solaris changes.
Here's a modified diff with the newer scripts.
Thanks,
Vincent
Comment 4 Vincent Cojot 2009-05-08 06:33:49 EDT
Created attachment 2061 [details]
Modified patch for safer LD_LIBRARY_PATH handling.
Comment 5 Vincent Cojot 2009-05-15 05:04:57 EDT
Created attachment 2065 [details]
Latest modified patch (plese use this one).

Thank you.
Comment 6 Ryan C. Gordon 2009-09-14 21:49:24 EDT
Fixed in svn revision #1608.

Please let me know if this is still good to go, as I can't test it.

--ryan.