Bug 4074 - Installation fails if pathname contains whitespace, % or "
Status: RESOLVED FIXED
Alias: None
Product: MojoSetup
Classification: Unclassified
Component: Everything
Version: unspecified
Hardware: PC Linux
: P3 normal
Assignee: Ryan C. Gordon
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2009-06-05 20:01 EDT by Reto Schneider
Modified: 2022-05-20 13:57:09 EDT
0 users

See Also:


Attachments
Escapes % and " in the .desktop file (1.13 KB, patch)
2009-06-05 20:04 EDT, Reto Schneider
changes to the installdir before calling xdg-desktop-menu (2.60 KB, patch)
2009-06-05 20:07 EDT, Reto Schneider

Description Reto Schneider 2009-06-05 20:01:50 EDT
Installation fails if pathname contains whitespace, % or "
Comment 1 Reto Schneider 2009-06-05 20:04:34 EDT
Created attachment 2074 [details]
Escapes % and " in the .desktop file
Comment 2 Reto Schneider 2009-06-05 20:07:16 EDT
Created attachment 2075 [details]
changes to the installdir before calling xdg-desktop-menu

changes to the install directory before calling xdg-desktop-menu. This avoids having whitespace in the arguments for xdg-desktop-menu.
Comment 3 Reto Schneider 2009-06-05 20:07:55 EDT
Again: I tried my best, but take care...
Comment 4 Ryan C. Gordon 2009-07-07 18:51:29 EDT
Comment on attachment 2074 [details]
Escapes % and " in the .desktop file

This is now hg changeset 689:0c5e12c9c3a9.

--ryan.
Comment 5 Ryan C. Gordon 2009-07-07 19:44:03 EDT
Comment on attachment 2075 [details]
changes to the installdir before calling xdg-desktop-menu


Ugh, the xdg-desktop-menu problem is a bug in XDG's shell script, not MojoSetup.   :(

I'd really rather not chdir() to work around it...let me think about it awhile longer.

--ryan.
Comment 6 Ryan C. Gordon 2009-07-07 20:42:03 EDT
Comment on attachment 2075 [details]
changes to the installdir before calling xdg-desktop-menu

hg changeset 695:682e60bf3a0f implements a chdir() strategy...the xdg-utils scripts are basically hopeless for fixing, so we'll have to work around it.

--ryan.
Comment 7 Ryan C. Gordon 2009-07-07 20:42:34 EDT
This bug is now fixed, as of the latest in revision control.

--ryan.
Comment 8 Ryan C. Gordon 2022-05-20 13:57:09 EDT
This bug report has migrated to our GitHub issue tracker:

https://github.com/icculus/mojosetup/issues/18