Bug 4243 - kick allbots doesn't free player slots
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: 1.36
Hardware: PC Linux
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2009-07-14 22:53 EDT by member998877
Modified: 2009-09-14 21:13:06 EDT
1 user (show)

See Also:

Attachments
Release bot slots immediately (1.25 KB, patch)
2009-09-01 15:29 EDT, Ben Noordhuis

Description member998877 2009-07-14 22:53:13 EDT 
"kick allbots" in ioquake3 v1.36 doesn't work:  player slots aren't getting freed. 
(i.e.) after playing 1 or 2 maps, bots won't load.


for example, this "server.cfg" (playing standalone on linux-x86_64) runs fine in v1.34, but not in v1.36 - bots in the 2nd and subsequent maps (after a \callvote nextmap in the console) won't load: 

server.cfg:
set d0 "map q3dm10; kick allbots; addbot daemia 3; addbot ranger 5; addbot grunt 3; addbot hossman 3; addbot lucy 4; addbot cadavre 3;  set nextmap vstr d1"
set d1 "map q3dm14; kick allbots; addbot biker 4; addbot ranger 4; addbot uriel 5; addbot hossman 5; addbot lucy 4; addbot slash 3; addbot sarge 3; addbot bitterman 5;  set nextmap vstr d2"
set d2 "map q3dm1; kick allbots; addbot lucy 3; addbot cadavre 5; addbot daemia 3; addbot bitterman 5; addbot grunt 4; addbot biker 3;  set nextmap vstr d3"
set d3 "map q3dm5; kick allbots; addbot grunt 5; addbot keel 3; addbot phobos 4; addbot sarge 5; addbot cadavre 4; addbot daemia 3;  set nextmap vstr d4"
set d4 "map q3dm2; kick allbots; addbot cadavre 3; addbot lucy 4; addbot daemia 3; addbot bitterman 5; addbot grunt 4; addbot biker 5;  set nextmap vstr d5"
set d5 "map q3dm6; kick allbots; addbot doom 5; addbot daemia 3; addbot bitterman 5; addbot slash 4; addbot sarge 3; addbot uriel 5; set nextmap vstr d0"
vstr d0




changing the sv_maxclients in my exec statement or in q3config.cfg doesn't help:
cd "/games/quake3/"
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:.
exec ./ioq3ded.x86_64 +set com_videoRam 256 +set com_hunkMegs 128 +set net_serverDedicated 1 +set net_allowCheats 0 +set sv_maxclients 13 +exec server.cfg
Comment 1 Ben Noordhuis 2009-09-01 15:29:40 EDT 
Created attachment 2109 [details]
Release bot slots immediately

Confirmed, also happens in stock Q3. The cause? A timing issue.

After a kick, the player slot is marked as CS_ZOMBIE and let to linger for sv_zombietime seconds before it is reused. This makes sense for real players because, thanks to latency, they won't immediately stop sending packets after a disconnect. All this doesn't apply to bots however: they're gone immediately after a kick and the server may safely reuse their slots.

And that is precisely what this patch does. =)
Comment 2 Ryan C. Gordon 2009-09-14 21:13:06 EDT 
This patch is now svn revision #1605.

--ryan.