Created attachment 2217[details]
The patch
Hi,
Here's a small patch adding support for desktop cycling in Openbox. It offers
two new actions, namely DesktopCycleLeft and DesktopCycleRight. They are
basically working like NextWindow and PreviousWindow, but switching desktops
instead of windows.
The patch is attached to this report and should apply to the current
3.4-working branch (parent is 7ab904b). The cycling code itself is mainly taken
from actions/cyclewindows.c. I've also added a new version of
screen_show_desktop_popup() with a variable popup time.
- Jonas
For the record: We purposely did not provide this action in Openbox because moving focus while the keyboard/mouse is grabbed would cause some applications to track their focus incorrectly.
With commit 11ecb7d2199d06b2929ba7e5d3c92c021038a0cc, I decided to no longer go this way. So I think we can restore the old behaviour to all the desktop switch actions, making them interactive with the popup showing similarly to the window cycling one.
I made the existing desktop cyling actions "interactive", i.e. they show the popup while you hold the modifiers, in commit 8ea8a39073aecd45f512646715ee7095d2102f74
Thanks for your effort with the patch!
Thanks for implementing, it seems to work great!
I've found a commit named 1a348576400b26dad3a58a81415c4c833fb4915c in your "work" branch which looks like the one I was searching for. I hope this change will make it into the next release.
- Jonas
Created attachment 2217 [details] The patch Hi, Here's a small patch adding support for desktop cycling in Openbox. It offers two new actions, namely DesktopCycleLeft and DesktopCycleRight. They are basically working like NextWindow and PreviousWindow, but switching desktops instead of windows. The patch is attached to this report and should apply to the current 3.4-working branch (parent is 7ab904b). The cycling code itself is mainly taken from actions/cyclewindows.c. I've also added a new version of screen_show_desktop_popup() with a variable popup time. - Jonas