Bug 4737 - [patch] Q3UI: Added range check for nettype, fixed nettype alignment
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: PC All
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2010-08-28 21:11 EDT by Zack Middleton
Modified: 2010-09-01 07:44:38 EDT
1 user (show)

See Also:

Attachments
Added range check for nettype, fixed nettype alignment (1.27 KB, patch)
2010-08-28 21:11 EDT, Zack Middleton
Fix nettype range check (495 bytes, patch)
2010-08-30 23:24 EDT, Zack Middleton

Description Zack Middleton 2010-08-28 21:11:54 EDT 
Created attachment 2426 [details]
Added range check for nettype, fixed nettype alignment

Added range check for nettype so it does not go beyond end 'netnames' array. Aligned nettypes to look better.
Comment 1 Thilo Schulz 2010-08-29 13:36:12 EDT 
fixed in r1790
Comment 2 Zack Middleton 2010-08-30 23:24:59 EDT 
Created attachment 2438 [details]
Fix nettype range check

Patch to exclude NULL from valid nettypes.
Comment 3 Zack Middleton 2010-08-30 23:26:32 EDT 
Reopening bug; range check allows index 3, NULL.
Comment 4 Thilo Schulz 2010-09-01 07:44:38 EDT 
Of course, you're right. Fixed in latest svn