Created attachment 2470[details]
Separate out the quake 3 renderer as a dll.
This patch separates out the Quake 3 renderer as a dll.
I copied over some code from xreal and it seems to work, though I think it stepped on a bunch of things that should probably be fixed.
Also I only implemented it on Windows.
Anyway, here's a patch, but it's sort of messy, I'll probably clean it up in the next few days.
Created attachment 2471[details]
New version of previous patch.
I've revised the patch slightly, re-enabling all of the code that was previously disabled, and adding a few more functions to refimport_t to do that.
Created attachment 2496[details]
adapted patch for Makefile
I have adapted your patch to use the standard Makefile and adapted it so that it compiles on linux and also cross-compiles to mingw.
I had to replace the .def file with a __declspec(dllexport) declaration, but MSVC supports that too, doesn't it ?
The tr_subs.c hack is plain ugly, so I removed all calls to Com_Printf etc. from the renderer, but they are still needed for q_shared.c :(
I also moved Q_acos into q_math.c, I think that's the proper place for it and makes it obsolete in tr_subs.c.
As the SMP code is only in the renderer the Makefile does no longer build a separate smp-client, but a renderer_smp dll, and you can select it via /cl_renderer. This means that /r_smp is a bit obsolete now, but I didn't change it, so you can use the smp-dll in non-smp mode...
Created attachment 2514[details]
fixed makefile patch for mingw
There was a small bug where QCALL (_stdcall) decorated the function export from the dll, so I reset it to a QDECL (_cdecl). As well, I renamed the DLL to ref_gl1.2x86.dll and the cvar to cl_ref, to mirror ref_gl.dll and vid_ref from Quake 2.
I tested the makefile with mingw and it works, but I left out the Visual Studio 2005 project this time, as it's sort of awkward for me to make, not having VS2005 on hand.
Created attachment 2566[details]
cleaned up patch
I have only removed a few ^M from tr_subs.c, added the missing #define for older gccs and added a copyright notice (copied from another file) to the new tr_subs.c file.
Created attachment 2604[details]
separate-renderer.diff
I just updated the patch to work with newest svn (the new minimize command broke it, so I moved the command into the renderer).
Created attachment 2651[details]
v4 of separate renderer patch
I updated gimhael's version of the patch, and added a few features.
First, USE_RENDERER_DLOPEN has been added to the Makefile. Setting this to 0 compiles the renderer as part of the client like before.
Second, the default for cl_renderer has been changed to opengl1, and the filename has been changed to renderer_opengl1_x86.dll. As well, if the dll specified in the cvar can't be found, it is reset to the default and tried again, instead of simply erroring out.
I tested this with mingw and it works, but haven't tested it anywhere else.
Created attachment 2855[details]
v5 of separate renderer patch
Just an update to make sure it still compiles. As before, tested on win32/mingw, works, but haven't tested anywhere else.
Created attachment 2874[details]
v6 of separate renderer patch
I have improved DLL loading from ioquake3 and adapted the patch for this new improved loading.
Timbo said he would look at this patch over the weekend if he finds the time.
Created attachment 2470 [details] Separate out the quake 3 renderer as a dll. This patch separates out the Quake 3 renderer as a dll. I copied over some code from xreal and it seems to work, though I think it stepped on a bunch of things that should probably be fixed. Also I only implemented it on Windows. Anyway, here's a patch, but it's sort of messy, I'll probably clean it up in the next few days.Created attachment 2471 [details] New version of previous patch. I've revised the patch slightly, re-enabling all of the code that was previously disabled, and adding a few more functions to refimport_t to do that.Created attachment 2496 [details] adapted patch for Makefile I have adapted your patch to use the standard Makefile and adapted it so that it compiles on linux and also cross-compiles to mingw. I had to replace the .def file with a __declspec(dllexport) declaration, but MSVC supports that too, doesn't it ? The tr_subs.c hack is plain ugly, so I removed all calls to Com_Printf etc. from the renderer, but they are still needed for q_shared.c :( I also moved Q_acos into q_math.c, I think that's the proper place for it and makes it obsolete in tr_subs.c. As the SMP code is only in the renderer the Makefile does no longer build a separate smp-client, but a renderer_smp dll, and you can select it via /cl_renderer. This means that /r_smp is a bit obsolete now, but I didn't change it, so you can use the smp-dll in non-smp mode...Created attachment 2514 [details] fixed makefile patch for mingw There was a small bug where QCALL (_stdcall) decorated the function export from the dll, so I reset it to a QDECL (_cdecl). As well, I renamed the DLL to ref_gl1.2x86.dll and the cvar to cl_ref, to mirror ref_gl.dll and vid_ref from Quake 2. I tested the makefile with mingw and it works, but I left out the Visual Studio 2005 project this time, as it's sort of awkward for me to make, not having VS2005 on hand.Created attachment 2566 [details] cleaned up patch I have only removed a few ^M from tr_subs.c, added the missing #define for older gccs and added a copyright notice (copied from another file) to the new tr_subs.c file.Created attachment 2604 [details] separate-renderer.diff I just updated the patch to work with newest svn (the new minimize command broke it, so I moved the command into the renderer).Created attachment 2646 [details] separate-renderer.diff Another update for the updated jpeg library.Created attachment 2651 [details] v4 of separate renderer patch I updated gimhael's version of the patch, and added a few features. First, USE_RENDERER_DLOPEN has been added to the Makefile. Setting this to 0 compiles the renderer as part of the client like before. Second, the default for cl_renderer has been changed to opengl1, and the filename has been changed to renderer_opengl1_x86.dll. As well, if the dll specified in the cvar can't be found, it is reset to the default and tried again, instead of simply erroring out. I tested this with mingw and it works, but haven't tested it anywhere else.Created attachment 2855 [details] v5 of separate renderer patch Just an update to make sure it still compiles. As before, tested on win32/mingw, works, but haven't tested anywhere else.Created attachment 2874 [details] v6 of separate renderer patch I have improved DLL loading from ioquake3 and adapted the patch for this new improved loading. Timbo said he would look at this patch over the weekend if he finds the time.