The fact that buttons in yes/no dialogs has styles given by
window.active.button.* means that their colors must be visible both on
top of window.active.title.bg.color and osd.bg.color. I've seen that a
good number of themes set window.active.title.bg.color=osd.bg.color
(explicitly or by default). That's fine, but what if you want a light
title bg but a dark osd bg? Chances are that buttons won't be clearly
visible either in the title or in the osd.
Please provide separate settings for each case.
Created attachment 2554[details]
Separate-theme-options-for-osd-prompt-buttons.patch
This patch add the following theme options for controlling buttons in osd prompts:
#### colors
#
# for the text inside the button
osd.button.unpressed.text.color
osd.button.pressed.text.color
osd.button.focused.text.color
#
# for the line art around the button
# (if you don't wan't the box just make box.color = bg.color)
osd.button.pressed.box.color
osd.button.focused.box.color
#### textures
#
osd.button.unpressed.bg
osd.button.pressed.bg
osd.button.focused.bg
The buttons can be in three states:
unpressed: neither clicked nor selected
focused: selected but not clicked
pressed: clicked (and of course selected)
I discarded the previous distinction between press and pfocus as in fact it was only a formal distinction, in that both appearances mimicked each other in every sense. It think that it was just inherited from the way titlebar buttons are managed so I decided to simplify it a bit.
All the options default in a way that preserves backwards compatibility:
osd.button.unpressed.text.color -> osd.active.label.text.color
osd.button.pressed.text.color -> osd.active.label.text.color
osd.button.focused.text.color -> osd.active.label.text.color
osd.button.pressed.box.color -> window.active.button.pressed.image.color
osd.button.focused.box.color -> window.active.button.hover.image.color
osd.button.unpressed.bg -> window.active.button.unpressed.bg
osd.button.pressed.bg -> window.active.button.pressed.bg
osd.button.focused.bg -> window.active.button.hover.bg
Created attachment 2554 [details] Separate-theme-options-for-osd-prompt-buttons.patch This patch add the following theme options for controlling buttons in osd prompts: #### colors # # for the text inside the button osd.button.unpressed.text.color osd.button.pressed.text.color osd.button.focused.text.color # # for the line art around the button # (if you don't wan't the box just make box.color = bg.color) osd.button.pressed.box.color osd.button.focused.box.color #### textures # osd.button.unpressed.bg osd.button.pressed.bg osd.button.focused.bg The buttons can be in three states: unpressed: neither clicked nor selected focused: selected but not clicked pressed: clicked (and of course selected) I discarded the previous distinction between press and pfocus as in fact it was only a formal distinction, in that both appearances mimicked each other in every sense. It think that it was just inherited from the way titlebar buttons are managed so I decided to simplify it a bit. All the options default in a way that preserves backwards compatibility: osd.button.unpressed.text.color -> osd.active.label.text.color osd.button.pressed.text.color -> osd.active.label.text.color osd.button.focused.text.color -> osd.active.label.text.color osd.button.pressed.box.color -> window.active.button.pressed.image.color osd.button.focused.box.color -> window.active.button.hover.image.color osd.button.unpressed.bg -> window.active.button.unpressed.bg osd.button.pressed.bg -> window.active.button.pressed.bg osd.button.focused.bg -> window.active.button.hover.bg