DescriptionZephaniah E. Hull
2004-01-09 17:50:06 EST
Patch will be added next, however this adds three new actions, though I do not
expect the patch to go in as is. (See the FIXME line in the patch, for instance.)
Anyways, the actions are as follows:
snapfocustopointer: This simply moves the focus to whatever is under the
pointer, falling back to the usual focus selection if there is nothing.
(Personally, this is setup to trigger in the raise/lower key bindings.)
snappointertofocus: This moves the pointer to the center of the display of
whatever is in focus.
And one that I consider least likely to be included, especially as is.
centerviewonfocus: This /attempts/ to move the viewport so that the center of
the window in focus is in the center of the screen, however it has a few issues
that I do not believe can be fixed.
1: It simply can not do anything at all if the VidMode extension is not present.
2: The user will almost always wish to call the snappointertofocus action
immediately after this one, as the viewpoint will always move to show the
pointer, resulting in the screen snapping back if the pointer would not have
been visible. (I do not however just call that action afterwards, because the
user might desire this function for some reason.)
As you can tell, I am horrible with names, and thus they could probably do with
a rename as well, and the utility function needs to be moved somewhere else.
But it all seems to work, so here it is.
Comment 1Zephaniah E. Hull
2004-01-09 17:52:39 EST
Comment 2Zephaniah E. Hull
2004-01-10 09:20:09 EST
Created attachment 162[details]
Updated patch.
This is an updated patch which includes a much less evil rewrite of
myGetGeometry, thanks to teru for the help on tracking things down.
the first action should probably not be an action, but an option you would set
in addition to followMouse, like followMouseStrict, so that focus is always
under the mouse, even when you're navigating with the keyboard (why anyone would
want that is beyond me though. if you're lucky, all you have to do is make the
option disable the client_action_start/_stop when your followMouseStrict option
is on)
it also looks a bit funny when you mix unsigned ints and gints
the last action is not likely to enter now, because i have removed support for the vidmode extension. i am still not sure about the second one. the first one will work in 3.3 by calling the already existing Unfocus action, it will move the focus to the window under the cursor if config_focus_follow is set. it did before too, but only if config_focus_last was not set.
Created attachment 161 [details] The patch.Created attachment 162 [details] Updated patch. This is an updated patch which includes a much less evil rewrite of myGetGeometry, thanks to teru for the help on tracking things down.