Bug 1968 - XML schema for configuration file is not up-to-date
Status: CLOSED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: 3.2
Hardware: PC Linux
: P2 minor
Assignee: Mikachu
QA Contact:
URL:
Depends on:
Blocks: 2582
 
Reported: 2004-10-05 04:09 EDT by James Michael Fultz
Modified: 2007-03-18 12:08:50 EDT
1 user (show)

See Also:


Attachments
Patch for `rc.xsd' to add new options and actions (2.36 KB, patch)
2004-10-05 04:14 EDT, James Michael Fultz
Adds new options and an action to `rc.xsd' (888 bytes, patch)
2004-10-06 11:09 EDT, James Michael Fultz
Greatly fixes the schema (22.32 KB, patch)
2006-07-18 19:20 EDT, Jonas Kölker
Fixes the schema even greaterly (22.65 KB, patch)
2006-07-21 10:39 EDT, Jonas Kölker

Description James Michael Fultz 2004-10-05 04:09:04 EDT
The XML schema file (rc.xsd) for Openbox's configuration file (rc.xml) is not
up-to-date as of version 3.2 of Openbox. It lacks some options and actions added
since version 3.1 of Openbox.
Comment 1 James Michael Fultz 2004-10-05 04:14:53 EDT
Created attachment 502 [details]
Patch for `rc.xsd' to add new options and actions

Most new additons were gleaned from `CHANGELOG', but I had to consult Openbox's
source for the context of some of them. While doing so, I discovered a few
more. ;-)

options: keepBorder, popupPosition, popupShow, hideDelay, hilightFirst,
warpPointer, xorStyle
actions: ToggleDockAutohide
Comment 2 Mikachu 2004-10-05 10:08:15 EDT
Thanks,
If you would like to rediff against current cvs where some of the options are
already listed, that would be nice (always do patches against cvs). Also there
is at least one typo in your patch (postition).
Comment 3 James Michael Fultz 2004-10-05 22:12:24 EDT
There is something about which I am uncertain. hilightFirst in the menu section
of the configuration file seems to do nothing. It doesn't seem to have a
function in the Openbox source code either. Though, I am not a C programmer; I
may be wrong. Would it be worthwhile to include hilightFirst in the
configuration file schema?
Comment 4 Mikachu 2004-10-06 08:40:21 EDT
heh, oops :) I'll remove it and change the default to what it does when off and
see if anyone notices.
Comment 5 James Michael Fultz 2004-10-06 11:09:33 EDT
Created attachment 504 [details]
Adds new options and an action to `rc.xsd'

OK. This patch is against the schema file from CVS. Here's hoping that I did
this right. ;-)
Comment 6 Jonas Kölker 2006-07-18 19:20:29 EDT
Created attachment 966 [details]
Greatly fixes the schema

This patch adds:

   * a shit load of minOccurs="0"
   * the 'delta', 'wrap', 'here' and 'linear' action arguments
   * the 'shade', 'iconic', 'skip_pager', 'skip_taskbar', 'fullscreen' and 'maximized' per-application setting elements, and the 'class' and 'role' attributes.
   * true/false and on/off to ob:yesorno, and renames it to ob:bool
   * the 'Reconfigure' and 'ToggleDockAutoHide' actions

and fixes:

   * double definitions of the "position" type
   * adds "center" as a value to (the new) window_position type (in addition to xs:integer)
   * s/unboundd/unbounded/
   * sorts the simple types alphabetically

and removes:

   * NextWindowLinear and PreviousWindowLinear
Comment 7 Jonas Kölker 2006-07-21 10:39:28 EDT
Created attachment 970 [details]
Fixes the schema even greaterly

This tweak renames stacking to layer, sets it as the type of <application><layer>, tweaks the maximization type, adds minOccurs="0" to <application>, and indents one line a bit more consistently.

.. in addition to the above patch.
Comment 8 Mikachu 2006-08-01 15:43:28 EDT
i'm going to hope you know what you're doing and commit this to cvs. thanks :).