Bug 2679 - invalid memory access
Status: CLOSED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: unspecified
Hardware: All Linux
: P2 blocker
Assignee: Mikachu
QA Contact:
URL:
Depends on:
Blocks: 2582
 
Reported: 2006-04-21 15:27 EDT by Derek Foreman
Modified: 2007-05-16 15:52:46 EDT
1 user (show)

See Also:


Attachments
Fix invalid memory access in renderer (2.15 KB, patch)
2006-04-21 15:32 EDT, Derek Foreman

Description Derek Foreman 2006-04-21 15:27:42 EDT
Parentrel decor can attempt to read outside of valid memory
Comment 1 Derek Foreman 2006-04-21 15:32:34 EDT
Created attachment 887 [details]
Fix invalid memory access in renderer

This should prevent illegal memory access in the renderer

Note that it prints a new error message to console if an attempt is made to render a window with invalid co-ordinates.  That should probably be fixed as well.
Comment 2 Tim Howe 2006-04-21 23:06:05 EDT
openbox still crashes when I launch kword on OpenBSD after applying this patch.

(gdb) bt full
#0  0x0d0889ed in kill () from /usr/lib/libc.so.39.0
No symbol table info available.
#1  0x0d0c510b in abort () at /usr/src/lib/libc/stdlib/abort.c:65
        p = (struct atexit *) 0x7f6a4000
        cleanup_called = 1
        mask = 4294967263
#2  0x1c01bbac in sighandler (sig=0) at openbox/mainloop.c:424
        it = (GSList *) 0x65b4
        i = 0
#3  0x03f6602d in ?? ()
No symbol table info available.
#4  0x0000000b in ?? ()
No symbol table info available.
#5  0x00000000 in ?? ()
No symbol table info available.
Comment 3 Mikachu 2006-08-02 21:14:35 EDT
patch applied.

@#2, that is not the most impressive backtrace i have seen today... can you do a bit better?