Bug 2867 - Team Votes don't work with F1/F2 keys
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC All
: P2 normal
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2006-09-14 12:45 EDT by Tony J. White
Modified: 2007-03-27 11:35:26 EDT
0 users

See Also:


Attachments
Cmd_Vote_f patch (3.91 KB, patch)
2006-09-14 14:17 EDT, Martin Doucha

Description Tony J. White 2006-09-14 12:45:40 EDT
To vote on a Team Vote you need to use the /teamvote command, but F1 and F2 only
seem to send the /vote command.

I think the functionality from /teamvote should be moved into that of /vote 
depending on which type of vote is currently active.
Comment 1 Martin Doucha 2006-09-14 14:17:15 EDT
Created attachment 1075 [details]
Cmd_Vote_f patch

This patch should do the trick. When there's no global vote, Cmd_Vote_f() now checks for teamvote and if there's one, it calls Cmd_TeamVote_f() before exiting. If there's no vote, it prints error message. If there's both global and team vote, /vote votes in the global one. You'll still have to use /teamvote to vote in teamvote in this case.
Comment 2 Tony J. White 2006-09-14 16:04:47 EDT
I didn't realize that the client actually supports both a team vote and a regular
vote at the same time.  This complicates things since we can't hijack the /vote command for /teamvote.
Comment 3 Martin Doucha 2006-09-14 16:14:17 EDT
Well, I'm not sure it does, I haven't seen both global and team vote at the same time but it looks like the support should be there. Global votes and team votes use different variables and they don't check aginst each other when they are called.
Comment 4 Tony J. White 2007-03-27 11:35:26 EDT
This is covered by revision 925.

Binds for "teamvote yes" and "teamvote no" can be set in the options menu and the
binds for these commands appear in the vote notification string.  They will default to F3 and F4 in the next release (I think).