Bug 2869 - "Change to map" or "Change to map EAT_MY_COCK" / tjw vote broken
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P2 normal
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2006-09-16 18:03 EDT by rasz
Modified: 2006-12-04 10:55:59 EST
0 users

See Also:


Attachments
"Change to map' (257.74 KB, image/jpeg)
2006-09-16 18:05 EDT, rasz
checks if a map exists before allowing it to be voted (764 bytes, patch)
2006-11-13 17:39 EST, M. Kristall
check if map exists (703 bytes, patch)
2006-11-20 08:27 EST, M. Kristall

Description rasz 2006-09-16 18:03:15 EDT
Server Kocour-cz (or any other with recent/newest TJW build). Lamers spam with stupid nonexistant map votes like in the subject :), or they make a weird vote when all you see is text 

VOTE(numberofseconds): "Change to map'

(pic later)and thats it, no info about Yes/No ratio, no map name

!listplayers
14 ^4H^7 0  ^4Unknown Player ^7 (*XXXXXXXX) ^1 ^7 1^7 ^7

So i try to vote him

Vote failed
Client 1 is not active
callvote: invalid player

WTF???
just after this he started to rename himself :

1^7 renamed to UnnamedPlayer
UnnamedPlayer^7 renamed to ^1^7Venda CZE
^1^7Venda CZE^7 renamed to 1
1^7 renamed to ^1^7Venda CZE

real Venda almost got voted :/

That moron griefer spammed "Change to map' shit several times, then switched teams and deconned :/


Iv got a demo, its kinda big (13MB) but i can send it if its needed.
Comment 1 rasz 2006-09-16 18:05:03 EDT
Created attachment 1080 [details]
"Change to map'
Comment 2 Martin Doucha 2006-09-18 07:53:06 EDT
The "Change to map ' is actually "Change to map 'lots-of-spaces'" Yes:x No:y. There're so many spaces that the end of the string is outside your screen. We'll have to make some trap call that will check for map presence before callvote mapchange is allowed to start a vote. Right now, map presence is checked in server/sv_ccmds.c:SV_Map_f() AFTER the vote passes and /map is called.
Comment 3 M. Kristall 2006-11-13 17:39:26 EST
Created attachment 1145 [details]
checks if a map exists before allowing it to be voted

This is a patch against svn 840 (or whatever the last revision to change line numbers in g_cmds.c was). Works well on my server.
Comment 4 M. Kristall 2006-11-20 08:27:08 EST
Created attachment 1160 [details]
check if map exists

Don't ask why I was using a file handle. I don't know.
Comment 5 Tony J. White 2006-12-04 10:55:59 EST
Thanks, committed as changeset 858