Bug 2901 - make BUILD_CLIENT_SMP=1 doesn't build tremulous-smp
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC All
: P2 minor
Assignee: Tremulous Bugs
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2006-10-26 16:32 EDT by Martin Doucha
Modified: 2007-08-06 13:27:19 EDT
0 users

See Also:


Attachments
Makefile fix (384 bytes, patch)
2006-10-26 16:33 EDT, Martin Doucha
Makefile fix (384 bytes, patch)
2006-10-26 16:33 EDT, Martin Doucha
Makefile fix (384 bytes, patch)
2006-10-26 16:33 EDT, Martin Doucha

Description Martin Doucha 2006-10-26 16:32:28 EDT
When you run make BUILD_CLIENT_SMP=1, it doesn't build tremulous-smp. There's a little typo in the Makefile.
Comment 1 Martin Doucha 2006-10-26 16:33:23 EDT
Created attachment 1127 [details]
Makefile fix

This fix should also go to the backport patch.
Comment 2 Martin Doucha 2006-10-26 16:33:33 EDT
Created attachment 1128 [details]
Makefile fix

This fix should also go to the backport patch.
Comment 3 Martin Doucha 2006-10-26 16:33:49 EDT
Created attachment 1129 [details]
Makefile fix

This fix should also go to the backport patch.
Comment 4 Martin Doucha 2006-10-26 16:35:00 EDT
Ooops, sorry for the mess, Icculus has some bug in bugzilla right now, it kept complaining about some unknown field...
Comment 5 Tony J. White 2006-10-28 15:25:16 EDT
(In reply to comment #0)
> When you run make BUILD_CLIENT_SMP=1, it doesn't build tremulous-smp. There's a
> little typo in the Makefile.
> 

Note that SMP support does not work with SDL except on Mac OS X.  I don't know if it works for win32 or not.
Comment 6 Martin Doucha 2006-10-29 03:12:43 EST
Yes, I'm aware of that. However, "doesn't work" and "never gets compiled" are two completely different things. Even if it doesn't work, Makefile should allow building it. Right now, it ignores the tremulous-smp target regardless of BUILD_CLIENT_SMP.
Comment 7 Tim Angus 2007-08-06 13:27:19 EDT
Fixed this a revision or two ago...