Bug 2911 - Patch for cg_disableWarningDialogs
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P2 normal
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2006-11-05 14:03 EST by rasz
Modified: 2011-05-24 11:58:21 EDT
1 user (show)

See Also:


Attachments
svn diff vs revision 837 (16.45 KB, patch)
2006-11-05 14:05 EST, rasz
spam (33.89 KB, image/jpeg)
2006-11-05 14:05 EST, rasz
diff against 755 (18.63 KB, patch)
2006-11-16 22:51 EST, rasz

Description rasz 2006-11-05 14:03:36 EST
New patch for cg_disableWarningDialogs. 
cg_disableWarningDialogs 0 = default value, all warnings
cg_disableWarningDialogs 1 = no warnings aka SPAM THE F out of console
cg_disableWarningDialogs 2 = no warnings FOR REAL aka SHUT THE F UP

Why this patch? look at the attached screenshot, that happens when using
bind MOUSE5 "itemact medkit;buy helmet;buy larmour;buy gren;buy ammo"
in the middle of the fight, whole chat spammed with useless info.
Comment 1 rasz 2006-11-05 14:05:06 EST
Created attachment 1137 [details]
svn diff  vs revision 837
Comment 2 rasz 2006-11-05 14:05:57 EST
Created attachment 1138 [details]
spam
Comment 3 rasz 2006-11-05 14:08:46 EST
ok, major doh
https://bugzilla.icculus.org/attachment.cgi?id=978&action=view
and its not included in svn, so whats up with all the cgame patches? why only game patches go to svn and not cgame?
Comment 4 Martin Doucha 2006-11-06 06:53:49 EST
Maybe because game patches can be tested right away anywhere while cgame patches require their own release for testing? And since Tremulous 1.2.0 is faaaaaaar away in the future, there's no point in doing a special cgame testing release now.
Comment 5 rasz 2006-11-06 14:47:32 EST
?
there was no release since 1.1.0 and that didnt stop including game patches, so this argument is mood imho

>because game patches can be tested right away anywhere

anywhere being localhost or that one special server with right version, same would be true for cgame patches

>Tremulous 1.2.0 is faaaaaaar away in the future

/me thinks it should be SOOOO SOOOON :)

Ideal would be daily svn builds pushed to master server, servers pulling daily builds daily, clients pulling latest qvms from the server they are connecting to.
~100 servers x 400KB = 40MB daily, thats like nothing.
Comment 6 rasz 2006-11-06 16:31:32 EST
anyway "faaaaaaar away" for me = finding a way to run my cgame.qvm with current servers, this or mental hospital, I cant put up with current bugs :/
Comment 7 Tim Angus 2006-11-06 17:22:09 EST
Please stop using bugzilla as a discussion forum.
Comment 8 Risujin 2006-11-16 20:59:45 EST
This patch contains a flaw:

+      switch( cg_disableWarningDialogs.integer )
+      {
+       case 1
+       trap_Cvar_Set( "ui_dialog", "The alien team has too many players. Please wait until "

All of the case statements are missing colons. Since when does code like this compile?
Comment 9 rasz 2006-11-16 22:49:55 EST
HA, it was a trap, i was checking if anyone uses this code
or I was just lame and send code before compile :P , anyway :
Comment 10 rasz 2006-11-16 22:51:46 EST
Created attachment 1155 [details]
diff against 755

this one works 100% ok, im using it daily
Comment 11 Tim Angus 2006-12-29 15:44:52 EST
This patch is junk.
Comment 12 /dev/humancontroller 2011-05-24 11:58:21 EDT
this is fixed already.