Bug 2919 - g_suddenDeath
Status: RESOLVED INVALID
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P2 enhancement
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks: 2920
 
Reported: 2006-11-13 18:27 EST by M. Kristall
Modified: 2007-02-23 13:26:06 EST
0 users

See Also:


Attachments
the aforementioned patch (4.76 KB, patch)
2006-11-13 18:28 EST, M. Kristall
updated patch (3.64 KB, patch)
2006-11-30 09:11 EST, M. Kristall
g_suddenDeath (4.07 KB, patch)
2006-12-17 01:11 EST, M. Kristall

Description M. Kristall 2006-11-13 18:27:31 EST
This patch (against svn840) implements the g_suddenDeath cvar.

It holds the current sudden death status, making checking that really easy, allowing SD to be enabled via rcon (or by vote, when I submit that patch) with g_suddenDeathTime = 0, and allows sudden death to be safely disabled for the rest of the current match.
Comment 1 M. Kristall 2006-11-13 18:28:20 EST
Created attachment 1146 [details]
the aforementioned patch

patch against svn revision 840
Comment 2 M. Kristall 2006-11-30 09:11:06 EST
Created attachment 1174 [details]
updated patch

Updated for G_TimeTilSuddenDeath from svn852
Comment 3 M. Kristall 2006-12-17 01:11:23 EST
Created attachment 1200 [details]
g_suddenDeath

I updated the actual calculation of when sudden death should begin. This is much cleaner, but I know there's a better way to do this (especially with the stuff in revision 872). I'm still not quite sure how yet. So this is not quite a finished product, ready for inclusion.

The other patches didn't have the warmup stuff that was actually there (I guess I was trying to sneak in bug 2923 [which, now that I think about it, might not have removed the unnecessary stuff from the sudden death code]). This puts that !level.warmupTime in the right place.

On an aside, wouldn't it make more sense to handle stages in G_CalculateStages than G_CalculateBuildPoints?
Comment 4 M. Kristall 2007-02-23 13:26:06 EST
After closing bug 2920 (good riddance), I figured I should do something with this too since it was created for bug 2920. I thought maybe some of my code would be good and that this could stay open for that. What I found is this: my patch removed a redundant 'else'

  int         localHTP = g_humanBuildPoints.integer,
              localATP = g_alienBuildPoints.integer;
...
  else
  {
    localHTP = g_humanBuildPoints.integer;
    localATP = g_alienBuildPoints.integer;
  }


Certainly not good enough to stay open.