Bug 3009 - Exit - Quit inconsistency
Status: ASSIGNED
Alias: None
Product: Loki Setup
Classification: Unclassified
Component: Graphical setup (gtk)
Version: unspecified
Hardware: PC Linux
: P2 minor
Assignee: St
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2007-01-21 05:54 EST by kratz00
Modified: 2007-04-11 09:50:14 EDT
0 users

See Also:


Attachments
Picture (12.53 KB, image/png)
2007-01-21 05:54 EST, kratz00
Patch (1.34 KB, patch)
2007-01-21 06:00 EST, kratz00
Updated patch (5.41 KB, patch)
2007-04-11 09:50 EDT, kratz00

Description kratz00 2007-01-21 05:54:07 EST
The error messages says "Press 'Exit' to clean up...." but the button is named Quit.
Comment 1 kratz00 2007-01-21 05:54:59 EST
Created attachment 1237 [details]
Picture
Comment 2 kratz00 2007-01-21 06:00:10 EST
Created attachment 1238 [details]
Patch
Comment 3 St 2007-01-21 14:37:56 EST
Yeah, that happened after we introduced GTK 2 stock buttons in the Glade file.
Comment 4 St 2007-02-20 15:58:29 EST
Corrected, but I'm afraid it will break the localized strings for now.
Comment 5 kratz00 2007-02-27 17:46:50 EST
Whats the problem to replace all message ids (msgid) in the setup.po files too?
This should not break anything then.
Comment 6 St 2007-02-27 18:02:57 EST
The problem is simply that we'd have to have translators update every single changed string to reflect the change. I could only a few languages myself, and there are lots. I'd rather have the original though correct string in English show up than an outdated translated string, but it's not a big deal really.
Comment 7 kratz00 2007-02-28 16:18:51 EST
If we just replace 'Exit' with 'Quit' in the message ids (msgid) in all the setup.po files nothing should break also like the translations because 'Quit' is just another word for 'Exit' and it has the same meaning or am I wrong?
Comment 8 St 2007-02-28 17:25:22 EST
I agree, but the original bug report was precisely about this discrepancy. Should we care at all or not ?
Comment 9 kratz00 2007-02-28 18:08:14 EST
My problem is the messages say to press the Exit button and there is only a Quit button so my suggestion is the replace Exit with Quit.
You said this could be a problem because of the localized strings and my answer was that we change Exit to Quit also in the msgids of the setup.po files.
Comment 10 kratz00 2007-04-11 09:50:14 EDT
Created attachment 1306 [details]
Updated patch

I updated the patch, now it changes the msgids too and does not alter setup.gtk2.glade because you already did this.