Bug 3052 - Ban does not handle duplicate IPs properly
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Platform
Version: unspecified
Hardware: PC Linux
: P2 normal
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2007-03-09 11:23 EST by FooBar
Modified: 2007-03-13 15:04:47 EDT
1 user (show)

See Also:


Attachments
svn909 duplicate IP bans (1.30 KB, patch)
2007-03-13 11:24 EDT, Tony J. White
svn909 ban/namelog fixes (5.33 KB, patch)
2007-03-13 15:04 EDT, Tony J. White

Description FooBar 2007-03-09 11:23:39 EST
If two players connect from the same IP address, and the first player is banned: 

1) banning the second player by name simply adds another ban for the first player and does not auto-kick the second player.
2) banning the second player by player # (as shown in listplayers) returns an "invalid player number" message.

The second player CAN be successfully vote-kicked.
Comment 1 FooBar 2007-03-09 11:37:36 EST
Here's a link to a zipped Tremulous demo of a situation in which this occurred:

http://avalanche.admin.googlepages.com/prince.zip

The relevant time period starts at about 6:00 and ends around 13:30.  The two players from the same IP were "Lord of the A** Wipes" and "princeofpersia".  FooBar is me, trying to ban them.  It is not clear to me whether the order in which they connected, or the order in which they were banned, matters.
Comment 2 Tony J. White 2007-03-13 11:24:45 EDT
Created attachment 1291 [details]
svn909 duplicate IP bans

needs testing
Comment 3 Tony J. White 2007-03-13 15:04:37 EDT
Created attachment 1292 [details]
svn909 ban/namelog fixes


1) when using !ban with a slot number, only look at slot numbers
2) players with the same GUID/IP were not getting distinct namelog records

added at revision 910