Bug 3260 - CTF Assist awarded to player who captures the flag
Status: RESOLVED FIXED
Alias:
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: 1.33 SVN
Hardware: PC All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2007-07-11 22:37 EDT by Ben Stephens
Modified: 2009-10-06 10:13:04 EDT
2 users (show)

See Also:


Description Ben Stephens 2007-07-11 22:37:33 EDT 
This may only be apparent on a server with one player in the team, or even an empty server Im not sure but thats the way I found it.  Although judging by the code it would appear to not matter. 

In game/g_team.c   Team_TouchOurFlag()   where the bonuses are handed out the assist bonus does not check if player == other resulting in the player who captures the flag receiving both the capture points and an assist bonus providing CTF_RETURN_FLAG_ASSIST_TIMEOUT is not currently in effect.

Interestingly this does not occur in ID Software's production release of quake3.
Comment 1 beast 2007-08-27 14:57:18 EDT 
Looking at the code, the assist bonuses are only handed out if the player was the last one to return the flag or the player was the last one to frag the carrier. If there is only one person on a team, it seems that it would be quite possible (probable) that the same person that scored also was the last one to return the flag or frag the carrier. Therefore, it seems that this code is working as designed. Of course, whether or not that design is right or not is up to discussion. 

If this is the same code that is in idquake3, I can't imagine how it would not act similarly. Of course, if you did not return the flag or frag the carrier before you scored, you won't see the assist being handed out.
Comment 2 Ben Stephens 2007-09-02 19:27:59 EDT 
Hi just want to add to this one that the bonus problem is not bonuses added to members of the other team, but rather the capture assist bonus...  Its a single point awarded to the player on the same team as the flag capturer who is standing closest to that player at the time of capture.

If you load an empty map with ioquake3 and capture the flag you will see the 5 and 1 written together floating up from the flag and the player is awarded the assist, if you repeat this test on Quake3 from ID it doesn't do that.

Not a major issue I realise of course but since the bug report is here I felt I should clarify that the issue is actually the awards handed out to the capturing team rather than the opponents..

Thanks!
Comment 3 Thilo Schulz 2009-10-06 10:13:04 EDT 
fixed in rev. 1644
Note, as this is a change in the gamecode, you will need to have the updated QVMs installed on your server for this change to take effect.