When installing 10'000+ files with MojoSetup it eats up my whole 2 GB Ram while writing the metadata. Eventually it will finish, but it hangs my PC for about 5 minutes. write_manifest = false solves the problem, but forces me to use support_uninstall = false.
I created a minimalistic package to show the problem, hope it helps: ftp://reto-schneider.ch/10kfiles.tar.bz2
Thanks,
Reto
Yeah, we currently build the manifest as one long string, and write it as a text file in one shot. This was basic laziness on my part. I'll fix it.
--ryan.
Comment on attachment 2072[details]
Makes it faster
You have the right idea here with the speedup patch. Lua's '..' operator isn't meant for heavy lifting.
In fact, Lua's primary developer recommends the string table approach you took for a speed boost:
http://www.lua.org/gems/sample.pdf
("About Strings" section, page 22.)
The only problem is that this still leaves a big pile of immutable string fragments on the heap, just waiting for garbage collection, so I might move this into C code. I have to think about it a little more.
--ryan.
Comment on attachment 2070[details]
My compiler gives me a warning about that
Compiler warnings over printf() patch in now in revision control, hg changeset 680:9688bf9c72b3. Thanks!
--ryan.
hg changeset 681:4d1097947759 should fix the performance. Please note I haven't tested this change yet, and it might be totally broken, so don't rely on it tonight or anything.
--ryan.
Comment on attachment 2072[details]
Makes it faster
Okay, I've optimized and debugged by version of the performance patch, as of hg changeset 688:daaf73ab4961.
This _should_ be safe to use now.
--ryan.
Created attachment 2070 [details] My compiler gives me a warning about thatCreated attachment 2071 [details] exports chmod() into luaCreated attachment 2072 [details] Makes it fasterComment on attachment 2070 [details] My compiler gives me a warning about that Compiler warnings over printf() patch in now in revision control, hg changeset 680:9688bf9c72b3. Thanks! --ryan.Comment on attachment 2072 [details] Makes it faster Okay, I've optimized and debugged by version of the performance patch, as of hg changeset 688:daaf73ab4961. This _should_ be safe to use now. --ryan.Comment on attachment 2071 [details] exports chmod() into lua Obsoleting the chmod patch, as it isn't necessary anymore. --ryan.