Bug 3926 - MojoSetup throws "BUG: no options" when Setup.Option and Setup.OptionGroup
Status: RESOLVED FIXED
Alias: None
Product: MojoSetup
Classification: Unclassified
Component: Everything
Version: unspecified
Hardware: PC Linux
: P3 normal
Assignee: Ryan C. Gordon
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2009-01-06 06:14 EST by Reto Schneider
Modified: 2022-05-20 13:52:00 EDT
1 user (show)

See Also:

Attachments
config.lua (692 bytes, text/plain)
2009-01-12 12:47 EST, kratz00

Description Reto Schneider 2009-01-06 06:14:25 EST 
MojoSetup throws "BUG: no options" when Setup.Option and Setup.OptionGroup used in Setup.Package.

Line 1132 in mojosetup_mainline.lua seems to cause it. Replace ~= with == helps.

Thanks,
Reto
Comment 1 kratz00 2009-01-12 12:46:15 EST 
I think Reto is right, see the attached config.lua.
I get the same error as long as I don't comment out either the Setup.Option or the Setup.OptionGroup block.

From mojosetup_mainline.lua:1132

    if install.options ~= nil and install.optiongroups ~= nil then
        MojoSetup.fatal(_("BUG: no options"))
    end

This does not look right. For the attached test case this would mean
install.options is not nil and install.optionsgroups is not nil too.
As Reto stated it should look like:

    if install.options == nil and install.optiongroups == nil then
        MojoSetup.fatal(_("BUG: no options"))
    end

So the installer bails out only if both install.options and install.optiongroups are nil but not if both are unlike nil.
Comment 2 kratz00 2009-01-12 12:47:27 EST 
Created attachment 1954 [details]
config.lua
Comment 3 Ryan C. Gordon 2009-01-12 21:59:28 EST 
Ah, yeah, good catch. Basic logic mistake on my part.

Fixed in hg changeset 614:d3280f946e01, thanks!

--ryan.
Comment 4 Ryan C. Gordon 2022-05-20 13:52:00 EDT 
This bug report has migrated to our GitHub issue tracker:

https://github.com/icculus/mojosetup/issues/42