DescriptionAnthony Jacques
2009-01-17 04:54:20 EST
If a cvar value must contain spaces, and it is set via the commandline, you must quote the cvar value, so that Cmd_TokenizeString correctly parses it. However, the current code in main() rebuilds the commandline from tokenised arguments without regard to whether it was previously quoted.
The user impact of this is that for example, +set fs_homepath "C:\bleh\New Folder" has the quotes stripped, and fs_homepath is set to "C:\bleh\New", and the commandline parser doesn't know what to do with the unexpected "folder" token.
Created attachment 1956[details]
Patch which quotes any commandline arg that contains spaces
This isn't thoroughly tested - I haven't tried what happens with other whitespace chars, although I doubt there are many times when you get tabs etc in the commandline.
Created attachment 1956 [details] Patch which quotes any commandline arg that contains spaces This isn't thoroughly tested - I haven't tried what happens with other whitespace chars, although I doubt there are many times when you get tabs etc in the commandline.