You can reopen this bug when you have a patch for this which is reasonably clean. Otherwise, I don't see why we should support this developer mode specially for some border cases (namely the server running devmap is not a dedicated server). I don't feel like cleaning this up.

(In reply to comment #1)
> I don't see why we should support this developer mode
> specially for some border cases (namely the server running devmap is not a
> dedicated server)

Nothing keeps a server in developer mode from being dedicated. (You do know that developer mode means that sv_cheats is true, do you?)

Created attachment 2581 [details]
remove the abusable levelshot command and related hacks

As a supplement, you can provide a readme on how to make levelshots in the game (during intermission, do: set cg_draw2d 0; screenshot levelshot;).

> Nothing keeps a server in developer mode from being dedicated. (You do know
> that developer mode means that sv_cheats is true, do you?)

In your first post you said this bug only appears if sv_cheats is 1 AND the local server running is not a dedicated server, but has a client on top as well. So where is the problem?

I looked at your patch. Isn't there another way to fix this besides just removing all of the command? What is it used for anyways?

(In reply to comment #4)
> In your first post you said this bug only appears if sv_cheats is 1 AND the
> local server running is not a dedicated server, but has a client on top as
> well. So where is the problem?
No, the game is stopped in either case. However, if there is a local client running, then the outcome may even be useful.

> I looked at your patch. Isn't there another way to fix this besides just
> removing all of the command? What is it used for anyways?
I can move the hack to a console-only command, which will allow only a local or rconned client to put the game into an intermission state via this feature; the command will make the game spit out some other commands, which will execute successfully only if a client is running, and print "command not found messages" otherwise. A patch will follow shortly.

Apparently this feature was used during development to easily make screenshots taken from the "intermission camera location" of each map, for use in map thumbnails. I don't see a need for it, as a thumbnail for a custom map doesn't need to follow this convention, furthermore, such screenshots can be taken with little effort, without the help of this hack. Allow me to quote the code comments:

	// the clientLevelShot command is used during development
	// to generate 128*128 screenshots from the intermission
	// point of levels for the menu system to use
	// we pass it along to the cgame to make apropriate adjustments,
	// but we also clear the console and notify lines here

/*
==================
Cmd_LevelShot_f

This is just to help generate the level pictures
for the menus.  It goes to the intermission immediately
and sends over a command to the client to resize the view,
hide the scoreboard, and take a special screenshot
==================
*/

Created attachment 2582 [details]
reimplement the levelshot hack in a simpler and more secure way

Well, this is what I came up with. The levelshot command still client-to-server command (not a console command), but it will only do anything when it is issued by the local client (I assume this implies that both the (graphical) client and the server modules are running).

Created attachment 2583 [details]
combined patch

Created attachment 2584 [details]
Simple patch

Only allow levelshot to be used the "localhost" client, which is only true for client in the same binary as the server.

Reset cg.levelShot at map restart to fix no 2D issue.

Created attachment 2585 [details]
Simple patch w/ sp fix

Same as above but uses enum GT_SINGLE_PLAYER.

ok, check out r1873, all should be fixed here.