Bug 4629 - commands sent to client when disconnected
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: All All
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2010-05-11 01:27 EDT by M. Kristall
Modified: 2011-02-04 10:12:13 EST
2 users (show)

See Also:

Attachments
only forward commands when CS_ACTIVE (from Lakitu7) (466 bytes, patch)
2010-05-11 01:27 EDT, M. Kristall
proposed patch (fixes the regression for at least Team Arena) (1.01 KB, patch)
2010-11-11 17:24 EST, Simon McVittie

Description M. Kristall 2010-05-11 01:27:37 EDT 
Created attachment 2349 [details]
only forward commands when CS_ACTIVE (from Lakitu7)

Under certain circumstances, client commands still get forwarded to the game for clients that are no longer "connected". This is was not expected and caused a few crashes in Tremulous, and might affect other ioq3-based projects.
Comment 1 Zachary J. Slater 2010-10-25 02:47:33 EDT 
Thx, rev 1802
Comment 2 Simon McVittie 2010-11-11 17:23:32 EST 
This seems to regress single player Team Arena team games, in which the player joins a team before becoming ACTIVE (and can't join in the usual way, because the menu option is greyed).

Additionally checking for PRIMED seems to be sufficient; I'm not sure whether CONNECTED should count as connected too, or not.

Patch, which I'll attach in a moment:

http://git.debian.org/?p=users/smcv/ioquake3-upstream.git;a=commitdiff;h=refs/heads/commands-4629
Comment 3 Simon McVittie 2010-11-11 17:24:55 EST 
Created attachment 2476 [details]
proposed patch (fixes the regression for at least Team Arena)
Comment 4 Thilo Schulz 2011-02-04 10:12:13 EST 
Thank you Simon, applied.